Refactor props and targets of Microsoft.ML.OnnxRuntime and DllImport#27351
Open
Refactor props and targets of Microsoft.ML.OnnxRuntime and DllImport#27351
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
skottmckay
reviewed
Feb 16, 2026
| BeforeTargets="Build" | ||
| Condition=" | ||
| '$(SuppressOnnxRuntimePlatformCompatibilityError)' != 'true' AND | ||
| $([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) != 'ios' AND |
Contributor
There was a problem hiding this comment.
AFAIK there are no 32-bit iOS builds.
| '$(SuppressOnnxRuntimePlatformCompatibilityError)' != 'true' AND | ||
| $([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) != 'ios' AND | ||
| $([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) != 'android' AND | ||
| '$(PlatformTarget)' == 'x86'"> |
Contributor
There was a problem hiding this comment.
Do we need a check for an AnyCPU build (based on the previous implementation I'm guessing PlatformTarget may not have a value in that case) with Prefer32Bit set to true?
| <!-- ========================================================= --> | ||
| <!-- Windows native linking --> | ||
| <!-- ========================================================= --> | ||
| <ItemDefinitionGroup Condition="'$(PlatformTarget)' == 'x64'"> |
Contributor
There was a problem hiding this comment.
Should this condition also check the target is Windows or do we not have x64/arm64 as platform targets on Linux?
Comment on lines
-924
to
-927
| // 2. Try relative to assembly location (look into runtimes subfolders) | ||
| string assemblyLocation = null; | ||
| try { assemblyLocation = assembly.Location; } catch { } | ||
| if (!string.IsNullOrEmpty(assemblyLocation)) |
Contributor
There was a problem hiding this comment.
Do we still need this for development scenarios using an AnyCPU build? If that is the case dotnet might not copy from the runtimes directory to the build output as I don't think there's a specific RID at that point. It would do the copy when publishing though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the MSBuild assets and the C#
DllImportResolverto simplify native library deployment and improve cross-platform support (Windows, Linux, macOS). It also adds build-time verification to ensure native binaries are automatically copied to the output directory.Summary of Changes
1. Refactored MSBuild Assets (
props.xmlandtargets.xml)props.xml: Removed complex conditional logic for linking native libraries in Windows. The logic now focuses on providing the correct include and import library paths based on the target architecture (x64, ARM64).targets.xml:2. Streamlined
DllImportResolverruntimes/subfolders inNativeMethods.shared.cs.onnxruntimelibrary name to its platform-specific filename:onnxruntime.dlllibonnxruntime.solibonnxruntime.dylib3. End-to-End Build Verification
runtest.batandruntest.shto perform adotnet buildfollowed by a check for the existence of the native library (onnxruntime.dllorlibonnxruntime.so/dylib) in thebin/directory.Benefits Compared to Original Files
libprefix).dotnet testwhich might obscure build-time copy failures.Tests
Verified in Nuget Test and Foundry Local Package Pipelines